Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mean to review and comment blog posts #77

Open
ctmbl opened this issue Mar 27, 2023 · 3 comments
Open

Add a mean to review and comment blog posts #77

ctmbl opened this issue Mar 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ctmbl
Copy link
Contributor

ctmbl commented Mar 27, 2023

Currently blocked by #12

Problem

There is no mean, at the time, to review blog posts, for example to fix typos, add/ask for additional information or warn about dead links.
We should also be able to report blog posts.

Some Solutions

Here is a list (from the simplest to the most complex ones) of solutions I imagined:

  • a simple comment section below the post (this is for another issue but the author could be notified)
  • a mean to send private messages to/email the author, with or without some embedding to highlight/show the diff one would like
  • a more complex workflow where, after submitting a post an author, the post is in Review state (analogous to Allow article to be set to private #75) and the author must wait for, designated or not, reviewers approval (same as GitHub PRs or Root-Me solution submitting)
  • some other I didn't think of ??
@ctmbl ctmbl added the enhancement New feature or request label Mar 27, 2023
@atxr
Copy link
Contributor

atxr commented Mar 27, 2023

This new feature is, from my pov, quite important, and interesting to add.
Regarding the solutions you proposed:

  • I understand the idea of a Review state, but I think it's too much work for the maintainers of the blog, and will probably slow the publication process. Nevertheless, we talked about this review process for bloggers who wouldn't have a "iScsc member" or "Verified user" badge, and I totally agree for that!
  • The private message way isn't the best solution for me because I don't think we should make a difference between normal comments (like question, greetings, extra information from other users...) and review comments (typos...). There could be a Type of comment field which would change the color, visibility and priority of comments, but otherwise they should be handled the same way. I don't think making them private is a good solution.
  • The last (first 🙃) solution is the best for me. I think it's time to implement a comment feature. You sorted this solution as the simplest but it's the most difficult I think 😉

Here is a none exhaustive TODO if we choose this solution:

  • Update the database to add "comments" backend
  • Add API endpoint to Create/Read/Update/Delete (CRUD) comments backend
  • Update frontend to add comments bellow the blog posts frontend

Fell free to raise other issues to tackle!

@ctmbl
Copy link
Contributor Author

ctmbl commented Mar 27, 2023

@atxr
Thanks for the answer!

I'd like comments section so I'm happy you prefer it too.
However we should first make the blog posts editable don't you think?

@atxr
Copy link
Contributor

atxr commented Mar 28, 2023

Yes of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants