Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icarus launcher shows (possibly) wrong IP address for the browser connection #51

Open
alyyasser opened this issue Aug 27, 2023 · 3 comments
Labels
Bug Something isn't working as intended Cosmetic Visual / rendering bug

Comments

@alyyasser
Copy link

image
I was trying to open a terminal on my tablet, and then i realized that the IP address shown on the launcher was incorrect. it was neither my local IP address, nor my public one.

@iaincollins
Copy link
Owner

Thanks for flagging this!

What's going on here is that it grabs the first IP address on an interface it finds and suggests that. Sometimes that's a weird internal address on a virtual adapter or a VPN interface or something like that.

It used to display a list of all known IP address but because that was confusing and there isn't currently space in the UI to handle multiple address, I changed it to just display the first address as that works okay for 90% of folks. I should get around to addressing that though so will leave this open.

@iaincollins iaincollins added Bug Something isn't working as intended Cosmetic Visual / rendering bug labels Dec 3, 2023
@alyyasser
Copy link
Author

sorry for the very late update, it seems like you were right, the issue were surfaced when i have my vpn on, when i turned it off, it works normally. probably should filter the network interfaces by only LAN or Wi-Fi if possible.

@Rum-Monk
Copy link

Just adding to this that it would be nice to have the option to manually specify the IP and port.

I ran into the same issue. Luckily, once the launcher is running it will stick with whichever IP it originally picked. So disabling the VPN, launching ICARUS. then enabling the VPN after allows you to still have the VPN going with ICARUS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended Cosmetic Visual / rendering bug
Projects
None yet
Development

No branches or pull requests

3 participants