-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash.difference
dependency
#48
Comments
This will dramatically increase the likelihood that an unrelated CVE will implicate this package. I strongly suggest preferring the per-method packages, and leaving it to app consumers to handle deduping with their bundler config. |
Thanks for the v5 heads-up 🙌 To be fair, I'd probably drop the // Before
var unknownOptions = arrayDifference(
Object.keys(optionsObject),
supportedOptions
);
// After
var unknownOptions = Object.keys(optionsObject)
.filter(function (optionName) {
return supportedOptions.indexOf(optionName) === -1;
}); Happy to accept a PR! |
|
|
Oh, I was deceived by https://node.green/ |
lodash.difference
to lodash
lodash.difference
dependency
See https://lodash.com/per-method-packages for reasons for change.
I can send PR.
The text was updated successfully, but these errors were encountered: