Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Source maps missed in the package #1861

Open
diarmind opened this issue Feb 20, 2024 · 1 comment
Open

[BUG] Source maps missed in the package #1861

diarmind opened this issue Feb 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@diarmind
Copy link

What is the current behavior?

Files into nextjs-pino package point to source maps with source mapping url comments. For example //# sourceMappingURL=LoggerErrorInterceptor.js.map in node_modules/nestjs-pino/LoggerErrorInterceptor.js.
There is no .map.js files exist in the package.
Compiling server with webpack with an option "devtool": "source-map" and source-map-loader results in warnings

Failed to parse source map from '<your-app-path>/node_modules/nestjs-pino/InjectPinoLogger.js.map' file: Error: ENOENT: no such file or directory, open '<your-app-path>/node_modules/nestjs-pino/InjectPinoLogger.js.map'

What is the expected behavior?

.js.map files are included in the package. source-map-loader is able to locate source maps.

Please provide minimal example repo, not code snippet. Without example repo this issue will be closed.

Will make an example in days.

Please mention other relevant information such as Node.js version and Operating System.

Not specific to the environment.

@diarmind diarmind added the bug Something isn't working label Feb 20, 2024
@diarmind diarmind changed the title [BUG] [BUG] Source maps missed in the package Feb 20, 2024
@iamolegga
Copy link
Owner

@diarmind so, the solution here is just to ship source maps in the npm package as well, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants