Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 🐞 Incorrect Dhuhr Prayer Time in Egypt #59

Open
moha-b opened this issue Apr 7, 2024 · 0 comments
Open

[Bug] 🐞 Incorrect Dhuhr Prayer Time in Egypt #59

moha-b opened this issue Apr 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@moha-b
Copy link

moha-b commented Apr 7, 2024

Describe the bug

The test for calculating prayer times in Egypt is failing due to an inconsistency in the Dhuhr prayer time.
Here's a breakdown of the issue:

Test Result:

Expected Dhuhr Time: 11:53 AM
Actual Dhuhr Time: 11:54 AM
Difference: 1 minute later than expected
The ASR prayer is also included, but the difference is 1 hour and 1 minute.

this is the successful state

test('Test Prayer Time in Egypt', () {
    final coordinates = Coordinates(26.0590358, 32.2320519);
    final date = DateComponents.from(DateTime.now());
    final params = CalculationMethod.egyptian.getParameters();
    params.madhab = Madhab.hanafi;

    final prayerTimes = PrayerTimes(coordinates, date, params);

    expect(DateFormat.jm().format(prayerTimes.fajr), '4:10 AM');
    expect(DateFormat.jm().format(prayerTimes.sunrise), '5:36 AM');
    expect(DateFormat.jm().format(prayerTimes.dhuhr),
        '11:54 AM'); // 11:53 based on Google
    expect(DateFormat.jm().format(prayerTimes.asr),
        '4:24 PM'); // 3:23 based on Google
    expect(DateFormat.jm().format(prayerTimes.maghrib), '6:11 PM');
    expect(DateFormat.jm().format(prayerTimes.isha), '7:27 PM');
  });

Screenshots

image

Environment

  • Dart Language Version: 3.3.3
  • Flutter Version: 3.19.5
  • Adhan-Dart Version: ^2.0.0+1
@moha-b moha-b added the bug Something isn't working label Apr 7, 2024
moha-b added a commit to moha-b/alquranalkareem that referenced this issue Apr 8, 2024
the result not accurate at `dhuhr` and `asr` follow the issue [#59](iamriajul/adhan-dart#59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant