Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Firefox selection by double click #5560

Closed
k0ka opened this issue Nov 16, 2023 · 2 comments
Closed

Regression: Firefox selection by double click #5560

k0ka opened this issue Nov 16, 2023 · 2 comments

Comments

@k0ka
Copy link

k0ka commented Nov 16, 2023

Description
Selecting a block in Firefox via double click doesn't allow to remove formatting.

Recording

slateissues.mov

Steps
To reproduce the behavior:

  1. Go to https://www.slatejs.org/examples/richtext
  2. Double click on a word to select it.
  3. Click on the "bold" button.
  4. Deselect.
  5. Double click on the same word again to select it.
  6. Click on the "bold" button.

Expectation
The bold button must be active and the font must get to normal after clicking on the "bold" button again.

Environment

  • Slate Version: 0.98.0, 0.98.4, 0.101.0
  • Operating System: MacOS, Windows 10
  • Browser: Firefox

Context
This bug was reintroduced in slate-react 0.98.0. It was working properly in slate-react 0.97.2

I think it is the same bug as #3336 (or #4793) which was fixed in #5275 and reintroduced in #5486

@tdaron
Copy link
Contributor

tdaron commented Dec 9, 2023

+1 with slate version 0.101.1, firefox 120.0, linux

@12joan
Copy link
Contributor

12joan commented Dec 13, 2023

This can be closed as completed: #5580

@k0ka k0ka closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants