Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datafusion): datafusion enhancements #9544

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Jul 10, 2024

  • change collect to execute_stream, collect pulls all the data in memory, execute_stream only pulls partial data (reducing memory consumed)

  • fix creation of table with uppercase name and object (pa.Table, pd.DataFrame, etc)

  • remove the use of strings literal for dialect

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@mesejo mesejo force-pushed the fix/datafusion-enhancenments branch from 81b3369 to 445ab38 Compare July 10, 2024 14:17
@lostmygithubaccount lostmygithubaccount changed the title enh: datafusion enhancements feat(datafusion): datafusion enhancements Jul 10, 2024
@lostmygithubaccount lostmygithubaccount added feature Features or general enhancements datafusion The Apache DataFusion backend labels Jul 10, 2024
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one comment, thanks!

ibis/backends/datafusion/__init__.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added this to the 9.2 milestone Jul 10, 2024
@mesejo mesejo force-pushed the fix/datafusion-enhancenments branch from 445ab38 to 2383474 Compare July 10, 2024 21:23
@mesejo
Copy link
Contributor Author

mesejo commented Jul 10, 2024

Thanks for the review @cpcloud

change collect to execute_stream, collect pulls all the data in memory
execute_stream only pulls partial data (reducing memory consumed)

fix creation of table with uppercase name and object (pa.Table, pd.DataFrame, etc)

remove use of strings literal datafusion, for dialect
@mesejo mesejo force-pushed the fix/datafusion-enhancenments branch from 2383474 to 18190a6 Compare July 10, 2024 21:24
@mesejo mesejo requested a review from cpcloud July 10, 2024 21:25
@cpcloud
Copy link
Member

cpcloud commented Jul 15, 2024

Sorry for the delay, merging!

@cpcloud cpcloud merged commit f11ca43 into ibis-project:main Jul 15, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion The Apache DataFusion backend feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants