Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Switch height #3

Open
pruzand opened this issue Oct 22, 2014 · 9 comments
Open

Increase Switch height #3

pruzand opened this issue Oct 22, 2014 · 9 comments

Comments

@pruzand
Copy link
Member

pruzand commented Oct 22, 2014

The current height of the Switch is too small on mobile devices which makes it hard to use.
(fyi the Switch height is defined from the current value of the active line-height css property, which seems to be the one set on body from what I see. Also, note that changing this property at this level would also benefit to the other controls in the Settings panels, which are also quite small on mobile because of this )

@cjolif
Copy link

cjolif commented Oct 23, 2014

Does it mean we might want to revisit our default sizing, at least on mobile? (we are supposed to be multichannel so in some way users should not have to do things to run correctly (default sizing included) on mobile & desktop?

@pruzand
Copy link
Member Author

pruzand commented Oct 24, 2014

in some way users should not have to do things to run correctly (default sizing included)

I understand your point. But on the other hand, usually (at least that's my feeling), the line-height is something that is/would be defined by the developer when designing its page layout and widgets should fit accordingly. For ex, he will set a line-height on its container, and expects the children of the container to size and align properly (e.g. a label with a Switch on the same line). If we set a specific line-height on the Switch, it would make the layout task harder for the author IMO.

@cjolif
Copy link

cjolif commented Oct 24, 2014

So what about defaultapps.css? Or something like that?

@pruzand
Copy link
Member Author

pruzand commented Oct 24, 2014

defaultapps.css makes sense indeed.

@cjolif
Copy link

cjolif commented Oct 24, 2014

@dmandrioli, @wkeese, what do you think?

@wkeese
Copy link
Member

wkeese commented Oct 24, 2014

Sure, having an opt-in defaultapp.css file makes sense to me. Actually, I thought we had that already.

@cjolif
Copy link

cjolif commented Oct 24, 2014

@wkeese yes we already have that file, I was just looking for opinions of whether that file should also contain maybe some default values for mobile like line-height that are bigger so that the application can pick them up.

@dmandrioli
Copy link
Member

I think having a rule in defaultapp.css to increase line-height on mobile makes sense.
This could be done by a media query based on pixel density.

@cjolif
Copy link

cjolif commented Oct 24, 2014

@dmandrioli can you create an issue on delite (I think defaults.css is there) and assign it to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants