support form reset

[wkeese]

ComboBox, Select, Slider, and Toggle have code that supposedly supports form reset. I.E. when the user presses a <form>'s reset button, those widgets inside the <form> revert to their original values.

However, AFAICT there are no automated tests for these features, and not even manual tests.

Furthermore, the API to specify the original value is unclear. For example, given markup like:

<form>
   <d-slider value=5>
       <input value=10>
  </d-slider>
</form>

Then it's unclear whether the slider's original value should be 5 or 10, and correspondingly whether the reset button should set the slider to 5 or 10. The code seems inconsistent, for example the slider's original value may be 5, but the reset button may set the value to 10.

Form auto-fill and back-button support are related. In both cases, on page load the browser sets a value for the <input> which the widget should obey. I'm not sure what form reset is supposed to do in that case, but the widgets should do whatever native controls do.

The original commits for the form reset handling were:

• Combobox: 59e59c0
• Select: e80ca84
• Slider: c8cf2f0
• Toggle: 6ccd370

We should add automated tests, fix the code if it doesn't work, and document the right way to specify form widget's initial values.

[AdrianVasiliu]

• Select

With updated checkouts, I've tried the "reset" button in tests/functional/Select.html and it works for me as (I) expected. Tested with Chrome and FF / Win7. That is, after loading the test, I change the value of a single select, for instance I pick "Option 2". After "reset", it shows again "Option 1". Also, checking in the debugger the value prop. of the widget, it is consistent with what is shown in the DOM. It doesn't "clear" the value, it puts back the initial value. (The reset/submit buttons hold for the <select> inside the <form>, that is section #7 in the test.)

• Combobox

Indeed, reset is broken. It was working some (long) time ago. In the debugger I see the _initValue() function does get called as expected, but for some reason nowadays this doesn't restore the initial value. Some change somewhere (in Combobox or outside) broke it. Here too, there's only manual testing. As you said, there should be an automatic test similar to the one existing for submit.

[wkeese]

Combobox, Checkbox, and Radiobutton unconditionally create the this.valueNode <input> element in the template, rather than using the user-supplied one. If the user supplies one, you end up with two <input> controls inside the widget.

Select is a similar story except the template has a <select> node not an <input>