Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toaster test problems #717

Open
wkeese opened this issue Apr 10, 2019 · 0 comments
Open

Toaster test problems #717

wkeese opened this issue Apr 10, 2019 · 0 comments
Assignees

Comments

@wkeese
Copy link
Member

wkeese commented Apr 10, 2019

Issues:

  1. The toaster tests are [intermittently] failing in "Check toaster stacking permanent messages", at least on FF on Saucelabs.
  2. The failure error message isn't reported; rather the whole test just times out.

Meta-issues:

  1. The Promise chain doesn't make sense. For example:
.then(pollUntil(codeIns(perm1), [], intern.config.WAIT_TIMEOUT, intern.config.POLL_INTERVAL))
.then(function () {}, function errback1 () { throw new Error("perm1 not inserted"); })
.then(pollUntil(codeIns(exp2000), [], intern.config.WAIT_TIMEOUT, intern.config.POLL_INTERVAL))
.then(function () {}, function errback2 () { throw new Error("exp2000 not inserted"); })

When errback1 throws the error, we want the whole test to abort, but instead the error gets passed to errback2.

  1. The test is overly-complicated due to trying to use dynamic id's. Making the ids (and global variable names) deterministic would mean that the test wouldn't have to query the page to get the ids.
wkeese added a commit that referenced this issue Apr 11, 2019
Start to switch to deterministic ids to simplify tests.
Re-enable test disabled due to issue that is no longer an issue.
Disable tests that aren't working.
Various cleanup.

Refs #717.
Refs ibm-js/dpointer#23.
@wkeese wkeese self-assigned this Apr 11, 2019
wkeese added a commit that referenced this issue Apr 17, 2019
Start to switch to deterministic ids to simplify tests.
Re-enable test disabled due to issue that is no longer an issue.
Disable tests that aren't working.
Various cleanup.

Refs #717.
Refs ibm-js/dpointer#23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant