Add route for CNAME records for frontend and backend services #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victoremepunto
suggested changes
Feb 19, 2024
Comment on lines
+177
to
+194
| - apiVersion: route.openshift.io/v1 | ||
| kind: Route | ||
| metadata: | ||
| annotations: | ||
| description: A route to the backend | ||
| labels: | ||
| app: ${APP_NAME} | ||
| shard: internal | ||
| name: ibutsu-backend | ||
| namespace: ${NAMESPACE} | ||
| spec: | ||
| host: ${BACKEND_ROUTE_CNAME} | ||
| tls: | ||
| insecureEdgeTerminationPolicy: Redirect | ||
| termination: edge | ||
| to: | ||
| kind: Service | ||
| name: ibutsu-backend |
There was a problem hiding this comment.
why are we creating 2 routes ? shouldn't we just have the first one ? (the one that's used by the CNAME ?)
| @@ -25,7 +25,7 @@ objects: | |||
| template: | |||
| metadata: | |||
| labels: | |||
| app: ibutsu-backend | |||
| app: ${APP_NAME} | |||
There was a problem hiding this comment.
This is going to break the Service if the APP_NAME is not set correctly, the APP_NAME's default value is ibutsu-server - which is also used by all the other templates (with the same value), while the Service's label selector should use a unique value (otherwise more than one pod will match "app=ibutsu-server"
Comment on lines
+166
to
+169
| - name: FRONTEND_ROUTE_CNAME | ||
| displayName: Frontend Route | ||
| description: The CNAME URL of the frontend of the Ibutsu server | ||
| value: ibutsu.prod.com |
There was a problem hiding this comment.
Why do we need separate route parameters ? can't we use just 1 route, set the value at creation time with the CNAME URL ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.