Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ClassifyFailureTable to functional #546

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Convert ClassifyFailureTable to functional #546

merged 1 commit into from
Feb 26, 2025

Conversation

mshriver
Copy link
Contributor

@mshriver mshriver commented Jan 23, 2025 •
edited
Loading

  • Row expansion isn't working right now
  • yarn lint with unused states/setState hooks
  • MetaFilter errors on setFilter
  • Bug in main branch, error on expanding row:
    image

Working multi-classification and single classification

Tested on run classify failures tab, and on result page.

@mshriver mshriver added enhancement New feature or request frontend labels Jan 23, 2025
@mshriver mshriver force-pushed the failureclassify-react-3314 branch from 3f47c2c to d5afff6 Compare January 23, 2025 14:08
@mshriver mshriver mentioned this pull request Jan 23, 2025
Draft
@mshriver mshriver force-pushed the failureclassify-react-3314 branch 3 times, most recently from e0bc8d7 to 9409bf4 Compare January 23, 2025 18:57
@mshriver mshriver marked this pull request as draft January 23, 2025 19:19
@mshriver mshriver force-pushed the failureclassify-react-3314 branch from 9409bf4 to 504f8f5 Compare January 27, 2025 14:28
@mshriver mshriver mentioned this pull request Jan 27, 2025
Closed
@mshriver mshriver force-pushed the failureclassify-react-3314 branch from 504f8f5 to a5b5887 Compare January 27, 2025 16:29
@mshriver mshriver force-pushed the failureclassify-react-3314 branch 4 times, most recently from e9b1eda to 084d40a Compare February 25, 2025 15:15
@mshriver mshriver marked this pull request as ready for review February 25, 2025 15:15
LightOfHeaven1994
LightOfHeaven1994 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good and everything is working. But I left some suggestions

@mshriver mshriver force-pushed the failureclassify-react-3314 branch from 084d40a to decdeed Compare February 26, 2025 12:25
@mshriver
Convert ClassifyFailureTable to functional
e74d698 
Convert dropdown too

Split MetaFilter component file
Fix MetaFilter errors due to state update scope

Updates from great code review
@mshriver mshriver force-pushed the failureclassify-react-3314 branch from decdeed to e74d698 Compare February 26, 2025 12:26
@mshriver mshriver merged commit cc2ab42 into ibutsu:feature-react-functional Feb 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LightOfHeaven1994 LightOfHeaven1994 Awaiting requested review from LightOfHeaven1994

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshriver @LightOfHeaven1994