Convert TestHistoryTable #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
testhistory-3329
branch
3 times, most recently
from
efd1f99 to
0a33a33
Compare
mshriver
force-pushed
the
testhistory-3329
branch
2 times, most recently
from
501ed7d to
69b7057
Compare
mshriver
force-pushed
the
testhistory-3329
branch
4 times, most recently
from
2728694 to
988a1aa
Compare
Split LastPassed into new component
mshriver
force-pushed
the
testhistory-3329
branch
from
988a1aa to
62850bb
Compare
LightOfHeaven1994
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Small nitpicks, other than that - works fine! I see some duplicated requests still but all of them are correct. We can take a look on it outside of this PR later.
PS I also find TimeRange filter confusing a but as it's not clearly visible what option is selected. So I changed it to Select and will open PR for review after your 562 will be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from first review (Thanks @LightOfHeaven1994 !) are in, and it's behaving reliably now.
Only setting the history summary if the filters are non-empty now.