-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic for different keycloak auth paths #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
reviewed
Feb 13, 2025
mshriver
reviewed
Feb 13, 2025
mshriver
approved these changes
Feb 13, 2025
mshriver
pushed a commit
to mshriver/ibutsu-server
that referenced
this pull request
Feb 26, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues
mshriver
added a commit
that referenced
this pull request
Feb 26, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Co-authored-by: wcater803 <[email protected]>
wcater803
added a commit
to wcater803/ibutsu-server
that referenced
this pull request
Feb 27, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths Removed /auth from server_url Linting changes Hardcoded Keycloak paths (ibutsu#577) Added debug for frontend login
mshriver
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths Removed /auth from server_url Linting changes Hardcoded Keycloak paths (#577) Added debug for frontend login
wcater803
added a commit
to wcater803/ibutsu-server
that referenced
this pull request
Feb 27, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths Removed /auth from server_url Linting changes Hardcoded Keycloak paths (ibutsu#577) Added debug for frontend login Added logic for different keycloak auth paths (ibutsu#567) * Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues
wcater803
added a commit
to wcater803/ibutsu-server
that referenced
this pull request
Feb 27, 2025
* Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths Removed /auth from server_url Linting changes Hardcoded Keycloak paths (ibutsu#577) Added debug for frontend login Added logic for different keycloak auth paths (ibutsu#567) * Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths (ibutsu#577) Isolated deploy main (ibutsu#579) * Hardcoded Keycloak paths * Removed /auth from server_url * Linting changes Isolated deploy main (ibutsu#580) * Hardcoded Keycloak paths * Removed /auth from server_url * Linting changes * Debug statements * Debug statements * linting Isolated deploy main (ibutsu#583) * Hardcoded Keycloak paths * Removed /auth from server_url * Linting changes Added logic for different keycloak auth paths (ibutsu#567) (ibutsu#584) * Added logic for different keycloak auth paths * Modified code with suggestions * Fixed linting issues Hardcoded Keycloak paths Removed /auth from server_url Linting changes Hardcoded Keycloak paths (ibutsu#577) Added debug for frontend login Reverted internal login path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the itless environment, the Keycloak authentication instance was upgraded. In this upgrade the "/auth" endpoint was deprecated. This logic keeps the existing logic with the hardcoded "login/auth/keycloak" endpoint, but also adds in the availability to overwrite that by using the keycloakAuthPath (in the frontend) and KEYCLOAK_AUTH_PATH (foir backend) environment variables.