-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert projectlist #568
Convert projectlist #568
Conversation
52074e3
to
230c46d
Compare
230c46d
to
1f8e9bb
Compare
e93162f
to
f43fc4c
Compare
add empty state, fix filtertable rerender
f43fc4c
to
f4bcde9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look locally and proposing some changes. LMK if you have questions, we can have a call and I will explain.
P.S I just found out that we stopped using API calls when filtering projects (but we used it before) so my comments are correct only if we want to leave behavior when we use API calls when paginating and displaying results but using JS when project is filtered by title. TBH, I would ignore my comments and do fixes so we start using project filtering with backend request (and we can remove this useEffect)
So what we can do is HttpClient.get([Settings.serverUrl, 'admin', 'project'], {page: page, pageSize: pageSize})
add here filtering, and trigger this useEffect on filterText
change. But you will need to deal with Create your first project
thing that you added and I have an idea how to do that
ea4bb95
to
1b72b66
Compare
1b72b66
to
87d8269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
document is still re-rendering continuously it's just not visible other than the doc title
Table is rendering, filtering is working, delete is working, and there's a new empty state displayed instead of the table 'no results found' view.