Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert projectlist #568

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

mshriver
Copy link
Contributor

@mshriver mshriver commented Feb 14, 2025

document is still re-rendering continuously it's just not visible other than the doc title

Table is rendering, filtering is working, delete is working, and there's a new empty state displayed instead of the table 'no results found' view.

@mshriver mshriver force-pushed the projectlist-3333 branch 2 times, most recently from 52074e3 to 230c46d Compare February 17, 2025 12:54
@mshriver mshriver changed the title DRAFT convert projectlist Convert projectlist Feb 17, 2025
@mshriver mshriver added enhancement New feature or request frontend labels Feb 17, 2025
@mshriver mshriver marked this pull request as draft February 17, 2025 22:16
@mshriver mshriver force-pushed the projectlist-3333 branch 2 times, most recently from e93162f to f43fc4c Compare February 18, 2025 14:13
@mshriver mshriver marked this pull request as ready for review February 18, 2025 14:13
add empty state, fix filtertable rerender
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look locally and proposing some changes. LMK if you have questions, we can have a call and I will explain.

P.S I just found out that we stopped using API calls when filtering projects (but we used it before) so my comments are correct only if we want to leave behavior when we use API calls when paginating and displaying results but using JS when project is filtered by title. TBH, I would ignore my comments and do fixes so we start using project filtering with backend request (and we can remove this useEffect)

So what we can do is HttpClient.get([Settings.serverUrl, 'admin', 'project'], {page: page, pageSize: pageSize}) add here filtering, and trigger this useEffect on filterText change. But you will need to deal with Create your first project thing that you added and I have an idea how to do that

@mshriver mshriver force-pushed the projectlist-3333 branch 2 times, most recently from ea4bb95 to 1b72b66 Compare February 19, 2025 12:14
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@mshriver mshriver merged commit 70b8b96 into ibutsu:feature-react-functional Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants