Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstrumentTechnique #253

Open
agbeltran opened this issue Aug 11, 2021 · 0 comments
Open

Add InstrumentTechnique #253

agbeltran opened this issue Aug 11, 2021 · 0 comments
Labels
enhancement schema this involves changes to the ICAT schema

Comments

@agbeltran
Copy link
Member

In issue #230 about adding the Technique class and the DatasetTechnique class, there was also a discussion about adding InstrumentTechnique class. In the ICAT collaboration meeting on 10th August 2021, it was decided to create a different issue to track this separate discussion.

It is noted that while the Instrument class contains a type attribute that some facilities use to record the techniques relevant to the instrument, not all facilities use type in this way:
https://repo.icatproject.org/site/icat/server/4.11.1/schema.html#Instrument

For that reason, InstrumentTechnique would not replace the type attribute.

Considerations around overlaps between InstrumentTechnique and DatasetTechnique need to be analysed.

@agbeltran agbeltran added enhancement schema this involves changes to the ICAT schema labels Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement schema this involves changes to the ICAT schema
Projects
None yet
Development

No branches or pull requests

1 participant