Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POST implementation of put #162

Open
RKrahl opened this issue May 27, 2024 · 3 comments · May be fixed by #168
Open

Remove POST implementation of put #162

RKrahl opened this issue May 27, 2024 · 3 comments · May be fixed by #168
Labels
remove feature Proposal to remove some feature
Milestone

Comments

@RKrahl
Copy link
Member

RKrahl commented May 27, 2024

Just noticed the following in the documentation:

This is an alternative to using PUT on the put resource. All the same arguments appear as form fields. In addition there are two boolean fields wrap and padding which should be set to true as a CORS work around. These two fields will be removed shortly as they are only required by the old (GWT based) topcat.

It is years now that the old (GWT based) topcat is not in use any more, but these fields are still in the code. 😲

Check whether anybody still needs that and remove it if not.

@RKrahl RKrahl added the remove feature Proposal to remove some feature label May 27, 2024
@RKrahl RKrahl added this to the 3.0.0 milestone May 27, 2024
@RKrahl
Copy link
Member Author

RKrahl commented May 27, 2024

As an alternative we might consider to remove the POST implementation of the put call altogether. Need to be discussed in the collaboration.

@RKrahl RKrahl changed the title Consider to remove wrap and padding arguments in POST implementation of put Consider to remove POST implementation of put May 30, 2024
@RKrahl
Copy link
Member Author

RKrahl commented May 30, 2024

Discussed in today's collaboration meeting: we rather consider to remove the POST implementation of the put call altogether. I will announce that again to the mailing list and if no one objects, we will deprecate that call now and remove it in 3.0.0.

@RKrahl
Copy link
Member Author

RKrahl commented Jul 25, 2024

Now formally deprecated in v2.1.1.

@RKrahl RKrahl changed the title Consider to remove POST implementation of put Remove POST implementation of put Jul 25, 2024
@RKrahl RKrahl linked a pull request Jul 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove feature Proposal to remove some feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant