Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test data compatible with debug output of ewms-pilot #196

Open
3 tasks
mlincett opened this issue May 23, 2023 · 0 comments
Open
3 tasks

Make test data compatible with debug output of ewms-pilot #196

mlincett opened this issue May 23, 2023 · 0 comments
Labels
CI / Testing About CI and/or testing tech debt cleanup We need to do this to avoid tech debt

Comments

@mlincett
Copy link
Collaborator

mlincett commented May 23, 2023

The current format of test data is not perfectly compatible with the debug output of ewms-pilot. In particular:

  • in- pickles of ewms-pilot are dictionaries already containing reco_algo and pframe, while the current CI pipeline expects a bare pframe in the pickle, and wraps it in a dictionary with reco_algo with an auxiliary script. Should we drop the "old" format and update the test data for millipede_original?
  • the out pickle for comparison is expected to have a filename in the form *.out.pkl while ewms-pilot outputs something in the form f"out-{HASH}.pkl". We may want to make this consistent.

Additional remarks:

  • the scan of hese_event_01.json outputs a file named run00127907.evt000020178442.HESE_1.npz but is supposedly a simulated event. I find it a bit confusing.
@ric-evans ric-evans added tech debt cleanup We need to do this to avoid tech debt CI / Testing About CI and/or testing labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI / Testing About CI and/or testing tech debt cleanup We need to do this to avoid tech debt
Projects
None yet
Development

No branches or pull requests

2 participants