Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should probably just include pip dependencies in the conda creation #39

Open
JimCircadian opened this issue Mar 28, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JimCircadian
Copy link
Member

Keep on forgetting to manually install model-ensembler, which isn't an explicit dependency of icenet so needs to be included in the conda environment install. Why not do this to pin icenet too, provided it doesn't interfere with the solver (which is painful enough at the best of times).

Does this link to any changes you've been making recently @bnubald? Going to see if it works well as I'm recreating environments often at the moment across HPCs 😉

@JimCircadian JimCircadian self-assigned this Mar 28, 2024
JimCircadian added a commit to JimCircadian/icenet-pipeline that referenced this issue Mar 28, 2024
@bnubald
Copy link
Contributor

bnubald commented Mar 28, 2024

Thanks for checking @JimCircadian, it doesn't affect my changes 👋🏼 .

JimCircadian added a commit to JimCircadian/icenet-pipeline that referenced this issue Apr 12, 2024
JimCircadian added a commit to JimCircadian/icenet-pipeline that referenced this issue Apr 12, 2024
@bnubald bnubald added the enhancement New feature or request label Aug 1, 2024
@bnubald bnubald added this to the v0.3.0 milestone Aug 1, 2024
@bnubald bnubald changed the title Should probably just include pip dependecies in the conda creation Should probably just include pip dependencies in the conda creation Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants