Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the all_attributes Function #592

Open
InsertCreativityHere opened this issue May 31, 2023 · 0 comments
Open

Remove the all_attributes Function #592

InsertCreativityHere opened this issue May 31, 2023 · 0 comments
Milestone

Comments

@InsertCreativityHere
Copy link
Member

This function was added solely to support our old semantics of cs::namespace
(where it could be applied to multiple nested modules and we'd check the attributes on all of them).
So now that these semantics have been reworked into something more reasonable this function should be deleted.

However, this function started getting used as a hacky replacement for the include_parents flag which was removed in #574.
We should find some other way of checking parent attributes that doesn't involve all_attributes so it can be properly deleted.

@InsertCreativityHere InsertCreativityHere added this to the 0.2 milestone May 31, 2023
@InsertCreativityHere InsertCreativityHere modified the milestones: 0.2, 0.3 Nov 28, 2023
@InsertCreativityHere InsertCreativityHere modified the milestones: 0.3, 0.4 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant