Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need "make install" #10

Open
G-Ragghianti opened this issue Oct 4, 2021 · 7 comments
Open

Need "make install" #10

G-Ragghianti opened this issue Oct 4, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@G-Ragghianti
Copy link
Contributor

The CMake configuration should produce a "make install" target.

@G-Ragghianti G-Ragghianti added the enhancement New feature or request label Oct 4, 2021
@af-ayala af-ayala self-assigned this Oct 4, 2021
@af-ayala
Copy link

af-ayala commented Oct 4, 2021

Please, check my PR:
2cc33ba

@stomov
Copy link

stomov commented Oct 6, 2021

PR: 2cc33ba indeed adds a "make install", although as discussed there we (and users) may not technically need an install besides the executable benchmarks that get generated. Do we consider the issue resolved or something else specific must be "installed"?

@luszczek
Copy link
Contributor

luszczek commented Oct 6, 2021

I provided comments on #12 what I have in mind. Essentially, after cmake /path/to/fiber/src ; make ; make install the user would have /usr/bin/fiber that can be launched with mpirun. We don't have this functionality yet.

@af-ayala
Copy link

af-ayala commented Oct 6, 2021

We still do not have all benchmarks; therefore, nothing to provide in a bin folder suggested before. This was explained repeatedly.
Not knowing the state of the repository causes these issues. The contribution made in 2cc33ba, addresses the missing make install requested in this open issue, and provides a starting point to the future.
If the ideas you have in mind are so clear, perhaps it would be a good idea to contribute with code, instead with just comments and labeling other contributions as buggy and invalid. If a bin library is created, I would like to see what the developer would put in there. Whereas the current state of the repo has not any bugs.

@G-Ragghianti
Copy link
Contributor Author

I marked this as a feature enhancement because I know it is a feature that we will eventually want. That doesn't mean we have to implement it right away. We can keep items here as a way of keeping track of things that we will eventually address.

@luszczek
Copy link
Contributor

luszczek commented Oct 7, 2021

Consider using Github projects like I do for HPFT: https://github.com/icl-utk-edu/hpft/projects

@G-Ragghianti
Copy link
Contributor Author

G-Ragghianti commented Oct 7, 2021 via email

@af-ayala af-ayala removed their assignment Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants