Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the repo #22

Closed
6 tasks done
Nicogene opened this issue Nov 27, 2023 · 18 comments
Closed
6 tasks done

Publish the repo #22

Nicogene opened this issue Nov 27, 2023 · 18 comments
Assignees
Labels
domain-software Related to Software team-fix Related to Team Fix

Comments

@Nicogene
Copy link
Member

Nicogene commented Nov 27, 2023

We want to make this repository public and announce its existence on our main channels.

Tasks

Preview Give feedback
@Nicogene Nicogene added domain-software Related to Software team-fix Related to Team Fix labels Nov 27, 2023
@martinaxgloria
Copy link
Member

Regarding the new name of the repo, I was thinking about something like xcub_moveit2 or xcub_ros2. Since it contains the configuration files for both iCub and ergoCub, I think that xcub could be a solution to avoid using a long name like icub_ergocub_moveit2. Moreover, I saw that the convention with this kind of project is to use the _ros2 suffix even if they contain also MoveIt2-dependent packages. I don't have a strong opinion about the two, what do you think is the best?

cc @pattacini @Nicogene @traversaro

@pattacini
Copy link
Member

I like xcub 👍🏻

I would go for _moveit2 as that's our main contribution. Maybe people rely on _ros2 even with the presence of MoveIt2 packages since those are needed for other goals.

Could this be the case? If not, I'm fine with _ros2 too.

@traversaro
Copy link
Member

Can we use - instead of _ for consistency with the rest of repo in the organization?

@martinaxgloria
Copy link
Member

No prob, we go with xcub-moveit2 then?

@pattacini
Copy link
Member

Ok!

@pattacini
Copy link
Member

Name just changed!

@martinaxgloria
Copy link
Member

Thanks @pattacini!

@pattacini
Copy link
Member

Repository made public too.

@martinaxgloria please review the content in order to replace the old name with the new name.

@martinaxgloria
Copy link
Member

Hi @traversaro,
as per https://github.com/icub-tech-iit/tickets/issues/218, the last step to accomplish this task is to publish the iCub/ergoCub support on the MoveIt website. Are you in contact with some maintainers to understand how to proceed?

cc @Nicogene @pattacini

@traversaro
Copy link
Member

Hi @traversaro,
as per icub-tech-iit/tickets#218, the last step to accomplish this task is to publish the iCub/ergoCub support on the MoveIt website. Are you in contact with some maintainers to understand how to proceed?

In https://moveit.ros.org/robots/ they mentioned to either contact picknik or post on discourse. To understand more, I asked on MoveIt's Discord: https://discordapp.com/channels/717058325480734830/717148778238574623/1185146323687710791 . I will ping relevant persons if we do not get an answer. In the meanwhile, I would prepare a cool photo to replace the really old one in the moveit website.

@Nicogene
Copy link
Member Author

Hi @traversaro,
as per icub-tech-iit/tickets#218, the last step to accomplish this task is to publish the iCub/ergoCub support on the MoveIt website. Are you in contact with some maintainers to understand how to proceed?

In moveit.ros.org/robots they mentioned to either contact picknik or post on discourse. To understand more, I asked on MoveIt's Discord: discordapp.com/channels/717058325480734830/717148778238574623/1185146323687710791 . I will ping relevant persons if we do not get an answer. In the meanwhile, I would prepare a cool photo to replace the really old one in the moveit website.

We should add both iCub and ergoCub to the website, for the right photo to put we may ask @maggia80

@traversaro
Copy link
Member

Hi @traversaro,
as per icub-tech-iit/tickets#218, the last step to accomplish this task is to publish the iCub/ergoCub support on the MoveIt website. Are you in contact with some maintainers to understand how to proceed?

In https://moveit.ros.org/robots/ they mentioned to either contact picknik or post on discourse. To understand more, I asked on MoveIt's Discord: https://discordapp.com/channels/717058325480734830/717148778238574623/1185146323687710791 . I will ping relevant persons if we do not get an answer. In the meanwhile, I would prepare a cool photo to replace the really old one in the moveit website.

On MoveIt's discord @sea-bass kindly pointed out that we can just open a PR against this repo: https://github.com/ros-planning/moveit.ros.org/blob/789f50461b68b332b02695e3cb2976db3df0b5c7/robots/index.markdown?plain=1#L1594-L1603 , so probably we can just open a PR on that repo.

@maggia80
Copy link
Member

image
P058324-119830

P058324-463960

@martinaxgloria
Copy link
Member

Ok, thank you @traversaro! I'll open a PR.

@martinaxgloria
Copy link
Member

PR opened here:

cc @Nicogene @pattacini @maggia80 @traversaro

@martinaxgloria
Copy link
Member

PR merged. Now, you can find iCub and ergoCub within robots page on MoveIt website! 🚀

cc @Nicogene @pattacini @maggia80 @traversaro

@pattacini
Copy link
Member

Superb! 🏆

@maggia80
Copy link
Member

maggia80 commented Jan 3, 2024

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software team-fix Related to Team Fix
Projects
None yet
Development

No branches or pull requests

5 participants