Missing error message with Material outputs and "exodus=false" flag

[permcody]

Rationale

A user reported that the combination of saying "outputs=exodus" and having the flag "Outputs/exodus=false" does not result in any error message.

https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/moose-users/hijbCFxVGiY/MLL59M2YDAAJ

Description

Make sure that appropriate error messages are reported when conflicting options are supplied.

Impact

minor: usability

[shikhar413]

@GiudGiud digging into this a bit more. What I'm finding is that there is an error message ERROR The output object 'exodus' is not a defined output object when Materials/*/outputs=exodus and Outputs/exodus/false, which seems like expected behavior. However, what I'm finding is that when the Outputs block looks like:

[Outputs]
  exodus = true
  [other]
    type = Exodus
  []
[]

and Materials/*/outputs=exodus, then the material property gets outputted to both the input_out.e file and input_other.e file, which seems like incorrect behavior. Should I close this issue and create a new issue that addresses the new problem of material properties getting otuputted to both files?

[GiudGiud]

We need to know which commit fixed the problem if we are going to close this issue.
Opening a new issue for a new problem is fine

[shikhar413]

Hard to tell what the history of this error was without seeing the input file of the Google group user who reported this issue. Looking at the git blame of the code where The output object 'exodus' is not a defined output object error is thrown, this code was not changed after the issue was reported. My feeling is that the user incorrectly reported an error for something that was working properly.

[shikhar413]

Digging into this a bit more, I'm looking at the code from 2018 and the issue might be triggered by the fact that CommonOutputAction back then would create an AddOutputAction action for the Exodus object without assigning a name to it, however this commit by Logan assigns a name to the action created by CommonOutuputAction

90d660e

Hard to exactly pinpoint the root cause of the issue without running an executable from July 2018

[shikhar413]

Regardless, the materials output system is in need of general cleanup / maintenance, and I've created related issues:

#29787
#29781
#29780

I'm also not sure if the keywords Materials/*/outputs = all and Materials/*/outputs = none work as intended, will need to do more testing