Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the Factory (or alternatively just renaming it) #14

Open
uli-f opened this issue Oct 10, 2022 · 2 comments
Open

Splitting the Factory (or alternatively just renaming it) #14

uli-f opened this issue Oct 10, 2022 · 2 comments

Comments

@uli-f
Copy link

uli-f commented Oct 10, 2022

The RInChIGeneratorFactory hands out three different objects: RinchiGenerator, RinchiToReaction and RinchiDecomposition.

This factory produces so much more than just 'RInChIGenerator'! 😃

I would like to either

  1. introduce different factories for the three type of object or just
  2. rename to factory to something more general (RInChIFactory? RInChIProcessingFactory? ...?)

Personally, I prefer Option 1, but I would very much like to hear your opinion here.

@ntk73
Copy link

ntk73 commented Oct 17, 2022

I followed here the same pattern from cdk-inchi where they use only one factory.

@uli-f
Copy link
Author

uli-f commented Oct 17, 2022

Thank you for the clarification!

I would like to leave this issue open for now and put the question to the CDK maintainers when this branch is ready for them to have a look. I am happy to put the work in if changes are necessary, this issue serves just as a reminder.

I am happy for you to apply any kind of tag (question, PR question, ...) to this and any other issues that we (or maybe that should read I 😃) want to clarify with the CDK maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants