Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it okay to have multiple set-cookie headers? #127

Closed
ioquatix opened this issue Apr 30, 2018 · 2 comments
Closed

Is it okay to have multiple set-cookie headers? #127

ioquatix opened this issue Apr 30, 2018 · 2 comments

Comments

@ioquatix
Copy link
Collaborator

When proxying, say, HTTP/1.1, it's possible to receive a response with multiple set-cookie headers. How does this work in HTTP/2 and in this gem?

Do we need to do something to handle this?

@igrigorik
Copy link
Owner

Yes, per HTTP spec you can have multiple headers with the same name. The semantics of how such values are processed are up to the particular header. In case of Set-Cookie all values are processed.

Nothing h2 specific here.

@ioquatix
Copy link
Collaborator Author

Okay, great. I did end up looking through the code and it seem straight forward. I wasn't sure if it used a hash or an array of [key, value] pairs, but it's the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants