Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This repo has no a license. #145

Closed
xiejiangzhi opened this issue Feb 22, 2019 · 4 comments
Closed

This repo has no a license. #145

xiejiangzhi opened this issue Feb 22, 2019 · 4 comments

Comments

@xiejiangzhi
Copy link
Contributor

We need it. Please make a copyright, thanks.
@xiejiangzhi
Copy link
Contributor Author

xiejiangzhi commented Feb 22, 2019 •
edited
Loading

Ah.. I saw it in the README.
Maybe create a license file is better.

@igrigorik
Copy link
Owner

We declare the license in the gemspec — see docs.

Does that address it?

@xiejiangzhi
Copy link
Contributor Author

xiejiangzhi commented Feb 22, 2019 •
edited
Loading

Thanks for your answer.
For me, there is no problem. I'll close the issue.

image
On Github, if we have a LICENSE file in the root folder, it will show a license flag.
Please add it if you have time. Thanks again.

igrigorik added a commit that referenced this issue Feb 25, 2019
@igrigorik
add LICENSE
bf4a773 
Closes #145.
@igrigorik
Copy link
Owner

@xiejiangzhi ah, good call. Added LICENSE file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igrigorik @xiejiangzhi