Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SETTINGS_HEADER_TABLE_SIZE validation? #146

Closed
cjyclaire opened this issue Feb 26, 2019 · 1 comment
Closed

SETTINGS_HEADER_TABLE_SIZE validation? #146

cjyclaire opened this issue Feb 26, 2019 · 1 comment

Comments

@cjyclaire
Copy link
Contributor

while there is configuration option for :settings_header_table_size

settings_header_table_size: 4096,

there is no validation upon it for coming frames

when :settings_header_table_size

May we have validation on coming frames :settings_header_table_size value be lower or equal to the limit set by the SETTINGS_HEADER_TABLE_SIZE parameter?

https://http2.github.io/http2-spec/compression.html#encoding.context.update

@HoneyryderChuck
Copy link
Collaborator

closing this, as it's fixed in 1.0.0 . The patch is a bit more involved than the linked one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants