Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring frame size negotiation #151

Closed
HoneyryderChuck opened this issue Oct 10, 2019 · 1 comment
Closed

ignoring frame size negotiation #151

HoneyryderChuck opened this issue Oct 10, 2019 · 1 comment

Comments

@HoneyryderChuck
Copy link
Collaborator

HoneyryderChuck commented Oct 10, 2019

Coming from: https://gitlab.com/honeyryderchuck/httpx/issues/59 .

If you look at the shown frame negotiation, you can see that the server negotiates an increase of max frame size. However, this is never taken into account, as data frame parsing fails with common_header': Frame size is too large: 95846 (HTTP2::Error::CompressionError).

The main offender seems to be this condition, which doesn't do a thing.

@igrigorik
Copy link
Owner

Resolved via #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants