Subsequent playlists redownloads fail

[deldesir]

IIAB-DIAGNOSTICS - http://sprunge.us/oECy1e?en
This playlist https://www.youtube.com/playlist?list=PLGjplNEQ1it_oTvuLRNqXfz_v_0pq6unW of 14 videos was downloaded successfully and videos in order of ranking.. see screenshot.

Subsequent download attempts for these below have all failed in tasks but an empty bookshelf name is created.
https://www.youtube.com/playlist?list=PLGjplNEQ1it_oTvuLRNqXfz_v_0pq6unW 14 videos
https://www.youtube.com/playlist?list=PLfEr2kn3s-bo4LwlbyZugHPavhcdW8YMC 97 videos

Originally posted by @EMG70 in #146 (comment)

[deldesir]

@EMG70, please let me know if your tests went well after applying fix #151 to your issue so I can close this ticket.

[deldesir]

@EMG70, I am still looking for the causes of the failures you experienced. Want to give it another try?

[EMG70]

I will try again in next 3hrs and update you.

[EMG70]

IIAB-DIAGNOSTICS - http://sprunge.us/Kv2wBX?en
https://www.youtube.com/playlist?list=PL_c9BZzLwBRLVh9OdCBYFEql6esA6aRsi - 102 short videos in playlist ✅
https://www.youtube.com/playlist?list=PLr6-GrHUlVf96NLj3PQq-tmEB6woZjwEl - 53 short videos in playlist ✅
97/102 Videos were downloaded OK.A few videos failed https://www.youtube.com/watch?v=4e3dIeP93E8 and https://www.youtube.com/watch?v=D2KvDBSZA0w although they do play well on Youtube.I am not sure why,see screenshot below:

[deldesir]

UPDATE:

Subsequent redownloads of same playlists fail.

• missing videos: a 102-videos playlists run downloaded only 9 videos in the second redownload, 0 in the third one.

Subsequent downloads of different playlists work.

[holta]

@deldesir @EMG70

1. We need to monitor in early June confirming that PR Enable subsequent [re]downloads of playlists #151 fixed this sufficiently.

2. If so, we should close this in June after updating &/or clarifying the explanation posted here for everyone:

   [TODO] Supporting redownloading videos with the same ID
   https://github.com/iiab/calibre-web/wiki#todo-supporting-redownloading-videos-with-the-same-id

3. Somewhat related: - Videos failed and triggers "UNIQUE constraint failed: media.path" error on first retry/redownload #153

[holta]

@deldesir @EMG70

1. We need to monitor in early June confirming that PR Enable subsequent [re]downloads of playlists #151 fixed this sufficiently.

3 weeks have passed: can we get to a conclusion here now?

[EMG70]

I will test again and update you today.

[deldesir]

Subsequent redownload of 14-videos playlist succeeded:

[holta]

I will test again and update you today.

@deldesir let us know if we should close this issue, Thanks!

[deldesir]

Since subsequent playlist redownloading is not an issue anymore, this ticket should be closed.

[holta]

Since subsequent playlist redownloading is not an issue anymore, this ticket should be closed.

@EMG70 please confirm with your own URL & results when redownloading it! 🙏

[EMG70]

SUDO IIAB-DIAGNOSTICS - https://dpaste.com/9RWTE5BFG
I have used same playlists that had some failing videos last time.I can confirm all downloaded 100 % OK .I did not see any reason to re-download same playlist today as all were successful.
https://www.youtube.com/playlist?list=PL_c9BZzLwBRLVh9OdCBYFEql6esA6aRsi 102 videos ✅
https://www.youtube.com/playlist?list=PLr6-GrHUlVf96NLj3PQq-tmEB6woZjwEl 55 videos ✅

[holta]

Good enough.

Thanks @EMG70 and please keep an eye on any video redownloading gotchas that might re-surface in future!