Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request enable GutHub pages #632

Open
LesFerch opened this issue Mar 11, 2023 · 6 comments
Open

Request enable GutHub pages #632

LesFerch opened this issue Mar 11, 2023 · 6 comments

Comments

@LesFerch
Copy link

LesFerch commented Mar 11, 2023

Thank you for the great resource!

Small request: Please enable GitHub pages for the Master branch: Settings, Pages, Deploy from branch Master

Edit: I'm not sure that will work. I just downloaded the README.md and viewed it with a MD Viewer Chrome extension and it didn't display the emojis.

@rickstaa
Copy link

rickstaa commented Jun 1, 2023

Does https://github-emoji-picker.rickstaa.dev suit your need?

@LesFerch
Copy link
Author

LesFerch commented Jun 1, 2023

Yes, that's great. Thanks!

@LesFerch
Copy link
Author

LesFerch commented Jun 1, 2023

I've been playing around with the emoji picker and I see that clicking the emoji copies the shortcut to the clipboard, but there are often times when I want to get the Unicode character (or character sequence) copied to the clipboard. It's very awkward to try to highlight one emoji (unless it happens to be at the end of a list) so that I can right-click and Copy the character. Am I missing something? Is there an easier way to copy the emoji character(s)?

Maybe something like Shift-click, Ctrl-click, or Alt-click to copy the Unicode character(s) instead of the shortcut?

@rickstaa
Copy link

rickstaa commented Jun 2, 2023

I've been playing around with the emoji picker and I see that clicking the emoji copies the shortcut to the clipboard, but there are often times when I want to get the Unicode character (or character sequence) copied to the clipboard. It's very awkward to try to highlight one emoji (unless it happens to be at the end of a list) so that I can right-click and Copy the character. Am I missing something? Is there an easier way to copy the emoji character(s)?

Maybe something like Shift-click, Ctrl-click, or Alt-click to copy the Unicode character(s) instead of the shortcut?

There was not, but since I loved your idea, I added it in https://github.com/rickstaa/github-emoji-picker/releases/tag/v1.4.0 🎉. You are welcome to suggest any other improvements.

@LesFerch
Copy link
Author

LesFerch commented Jun 2, 2023

Nice! Thanks again!

I do have one more suggestion... A toggle button to swap the Click and Shift-Click functionality. The button could be placed in the same area as the theme and language buttons and, of course, be saved like the other settings.

This idea is just a "nice to have". The Shift-click feature really is all the functionality I need. Thanks!

@rickstaa
Copy link

rickstaa commented Jun 2, 2023

Nice! Thanks again!

I do have one more suggestion... A toggle button to swap the Click and Shift-Click functionality. The button could be placed in the same area as the theme and language buttons and, of course, be saved like the other settings.

This idea is just a "nice to have". The Shift-click feature really is all the functionality I need. Thanks!

Since I loved your idea, I now also added the copy_type URL query parameter so that users can change the copy behaviour (i.e. https://github-emoji-picker.rickstaa.dev/?copy_type=unicode) 🚀. Since this setting will get stored in the browser, you only need to do this once. I think this will fit the needs of most users, but you're always welcome to create a feature request or pull request if you still want a button 👍🏻.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants