Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations that have no effect #281

Open
ArashVahabpour opened this issue Jul 10, 2021 · 0 comments
Open

Operations that have no effect #281

ArashVahabpour opened this issue Jul 10, 2021 · 0 comments

Comments

@ArashVahabpour
Copy link

ArashVahabpour commented Jul 10, 2021

Hi,
The two lines referenced below seem to have canceling effects (the second quoted line is the inverse of the sigmoid). I was wondering what has been the purpose of putting them.

s = torch.sigmoid(d)
reward = s.log() - (1 - s).log()

I think if the purpose has been to make this a Wasserstein GAIL, it would be nice to do sth like
if args.wasserstein... else...

@ArashVahabpour ArashVahabpour changed the title Useless operation Ineffective operation Jul 10, 2021
@ArashVahabpour ArashVahabpour changed the title Ineffective operation Operations that have no effect Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant