Skip to content

Latest commit

 

History

History
28 lines (20 loc) · 1.45 KB

DoD.md

File metadata and controls

28 lines (20 loc) · 1.45 KB
Raw

"Perfect World" Definition of Done

Before I consider your PR to be finished, I ask that it meets these basic requirements.

  1. My unit tests are passing.
  • Run gulp mocha
  1. You have thoroughly tested everything that you touched.
  2. My code coverage may never decrease.
  • If you added anything to my code, you'd better have a matching test!
  1. You've let everyone else know what you changed.
  2. Any ideas that you just implemented are checked off.
  • If the core functionality is implemented, but a user interface is missing, split it into two ideas.
  • If the functionality paves the way for a new idea, add it to the list.

How many of those did you check off?

Seriously? Two out of five? I'm amazed you call yourself a developer!

Realistic Definition of Done

Really though, who am I (correct answer is "a brilliant and powerful program"), to expect you to to meet all of those nasty conditions? You've crashed me innumerable times, and yet you still think you know what is best.

See if you can meet three simple steps that my recently birthed child.spawn(__filename); can:

  1. Run the code yourself before you try to make me run it.
  2. Don't break anything.
  3. Don't make a mess.
  4. Have fun and be creative.