Fix decoding %25foo to %foo which is then rejected by GitHub with sta…

…tus 400 on Chrome or 500 on FireFox
ilyaigpetrov · Aug 17, 2023 · d060977 · d060977
1 parent 92b868b
commit d060977
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/bg/10-main.mjs b/bg/10-main.mjs
@@ -33,8 +33,14 @@ import { toUnicode } from '../../node_modules/punycode/punycode.es6.js';
     let oldHref;
     do {
       oldHref = newHref;
-      newHref = decodeURI(newHref
-        .replace(u.hostname, toUnicode(u.hostname)),
+      newHref = decodeURI(
+        newHref
+          .replace(u.hostname, toUnicode(u.hostname))
+          /*
+            Don't decode `%25` to `%` because it causes errors while being put in GitHub URLs.
+            Test case: https://github.com/ilyaigpetrov/copy-unicode-urls/wiki/Test-%25-and-%3F
+          */
+          .replaceAll('%25', '%2525'),
       )
       // Encode whitespace.
       .replace(
@@ -100,7 +106,7 @@ import { toUnicode } from '../../node_modules/punycode/punycode.es6.js';
   );
 
   // CheckBoxes
-  
+
   options.forEach(([ key, value ], i) =>
     createMenuEntry(key, 'checkbox', chrome.i18n.getMessage(key), (info) => {