Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation is a toplevel type in v0.25.3 on crates.io #2353

Closed
Shnatsel opened this issue Oct 16, 2024 · 2 comments · Fixed by #2354
Closed

Orientation is a toplevel type in v0.25.3 on crates.io #2353

Shnatsel opened this issue Oct 16, 2024 · 2 comments · Fixed by #2354

Comments

@Shnatsel
Copy link
Contributor

The version of image published to crates.io as v0.25.3 contains Orientation as a toplevel type, so it must have been published before #2349 was merged.

We could either yank it and republish a newer commit, or just accept that Orientation is a toplevel type now and adjust git accordingly. I think yanking is a better option right now.

cc @HeroicKatora

@fintelia
Copy link
Contributor

I'd vote for yanking. 0.25.3 was published with commit fe94eab rather than the merge commit d52a194 (the current head commit on the main branch), which means the current crates.io release isn't actually from the main branch

@HeroicKatora
Copy link
Member

Sure, if that happened on top of the other Changelog issue then yanking seems fine to me. Sorry for the apparent communications issues :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants