Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed username and password in javascript #2

Open
normkatz opened this issue Sep 10, 2016 · 0 comments
Open

Exposed username and password in javascript #2

normkatz opened this issue Sep 10, 2016 · 0 comments

Comments

@normkatz
Copy link

Wondering why you're exposing the sendgrid account username and password in javascript via the extension in the function "buildQuickForm" in class CRM_Sendgrid_Form_SendGrid in the file SendGrid.php on lines 32-35 at path sites/default/local/CRM/extensions/com.imba.sendgrid-2.0/CRM/Sendgrid/Form.

class CRM_Sendgrid_Form_SendGrid extends CRM_Core_Form {

function buildQuickForm() {
    require_once('CRM/Core/Resources.php');
    else $attr = null;

    $el = $this->add('text', 'username', ts('Username'), $attr);
    if (!$is_writable)
        $el->setSize(40);
    $el = $this->add($is_writable ? 'password' : 'text', 'password', ts('Password'), $attr);

Do you have any plans to refactor and eliminate this and use server-side credentials instead?

Is there a sendgrid component you recommend that supersedes this one?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant