Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disabling individual area coords. #2

Closed
meljason opened this issue Mar 28, 2021 · 7 comments
Closed

[Feature] Disabling individual area coords. #2

meljason opened this issue Mar 28, 2021 · 7 comments
Assignees
Labels
Feature New Feature help wanted Extra attention is needed

Comments

@meljason
Copy link

Is your feature request related to a problem? Please describe.
It is not a big problem but I think a bool disabled function would be great as sometimes on site-plans, I want to disable certain sold-out area.

Describe the solution you'd like
Probably something like disable boolean that we can add when we declare the map const.

Describe alternatives you've considered
Currently I am updating the id to empty so that users cannot click on that certain area. But this is not the best solution because users can technically still click on it. It is just that it is not linked to that id because I removed it. A disable boolean would be a better way to do it.

@NishargShah
Copy link
Member

Great Feature, I am willing to add that feature to my project

@meljason
Copy link
Author

Awesome! Thank you very much. Great work!

@NishargShah
Copy link
Member

I am planning to add active: true | false in JSON.

If you are passing active: false in a specific area it will not highlight that specific area.

it will give similar results to that https://img-mapper.github.io/react-docs/?path=/story/examples-area--show-highlighted-area

@meljason
Copy link
Author

That's perfect!

@NishargShah
Copy link
Member

NishargShah commented Mar 28, 2021

Hello @meljason

Please upgrade your version to v1.0.4

Here are the docs https://img-mapper.github.io/react-docs/?path=/story/examples-area--in-array-show-highlighted-area

Thanks

@NishargShah
Copy link
Member

did you upgrade the package to v1.0.4?

@NishargShah NishargShah self-assigned this Mar 28, 2021
@NishargShah NishargShah added help wanted Extra attention is needed Feature New Feature labels Mar 28, 2021
@NishargShah NishargShah pinned this issue Mar 28, 2021
@meljason
Copy link
Author

@NishargShah Yes it works now. I just forgot to restart my localhost. Thank you!

@NishargShah NishargShah changed the title Disabling individual area coords. [Feature] Disabling individual area coords. Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants