Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply an Image-based Light file #71

Open
zachernuk opened this issue Oct 16, 2023 · 5 comments
Open

Supply an Image-based Light file #71

zachernuk opened this issue Oct 16, 2023 · 5 comments

Comments

@zachernuk
Copy link
Collaborator

At TPAC we agreed that specifying an image-based light (IBL) is an important component of a V1 implementation and specification. In addition to the specific name (environment map, lighting environment, IBL etc), there is the matter of structural representation, i.e. how it resides within the tree structure of the <model> markup itself.

I don't have a strong opinion but some candidates I can see are:

  1. An attribute on the <model> tag:
<model environment-map="warehouse.hdr">
  <source src="shelf.usdz"/>
</model>
  1. An attribute on the <source> tag
<model>
  <source src="shelf.usdz" environment-map="warehouse.hdr"  />
</model>
  1. An independent tag inside the <model> block
<model>
  <environment-map src="warehouse.hdr" />
  <source src="shelf.usdz"/>
</model>

Or some more complex nesting of <source> elements within such a tag. It should be simple, but my expectation is that the role and complexity of <model> will increase over time, so something expressive enough to meet some obvious needs would be useful.

@zachernuk
Copy link
Collaborator Author

/agenda

@probot-label probot-label bot added the agenda To be discussed at a future CG meeting label Oct 16, 2023
@mrdoob
Copy link

mrdoob commented Oct 16, 2023

Sharing this new HDR file format for awareness:
https://developer.android.com/guide/topics/media/platform/hdr-image-format

@cabanier
Copy link
Member

I don't remember that we agreed that version 1 needs this.
If we add it, my vote is for option 1.

@Yonet Yonet removed the agenda To be discussed at a future CG meeting label Oct 17, 2023
@zachernuk
Copy link
Collaborator Author

In #72, after finding value in the addition of a JS object for a model's root element, as well as looking forward to a future where a scene graph is appealing, I'm also leaning toward using that rootElement node to specify an IBL as well, among other capabilities.

The main benefit being that many web authors may want to override the IBL on subsets of the scene graph - e.g. a different environment map on the polished stainless steel to the lights affecting the brushed aluminum casing of a high-end desktop computer.

/facetoface

@zachernuk
Copy link
Collaborator Author

/tpac

@probot-label probot-label bot added the TPAC For discussion at TPAC label Sep 24, 2024
@Yonet Yonet removed the TPAC For discussion at TPAC label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants