Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some things are ignored when using reob #8

Open
monoxide0184 opened this issue Jan 7, 2013 · 3 comments
Open

Some things are ignored when using reob #8

monoxide0184 opened this issue Jan 7, 2013 · 3 comments

Comments

@monoxide0184
Copy link

I'm having issues in specific situations when trying to use reob to reobfuscate a mod. Specifically here's some examples I've pulled out with JD-GUI from the reob'ed jar. These two examples are from two different classes.

public <T extends Item> T getItem(String name)
{
  return (up)this.registeredMinecraftObjects.get(name);
}

// FloodFillState is a mod class
private List<FloodFillState> getBlocksToBreak(World world, int x, int y, int z, Block wood, int woodMeta, Block leaves, int leavesMeta) {
  // ... <snip>
}

These seem to be representative of all the issues we've run into.

@immibis
Copy link
Owner

immibis commented Jan 9, 2013

It doesn't handle generics at all, and reob hasn't been tested at all (there's a reason it's not in the GUI).
Btw, why aren't you using MCP for reob?

@monoxide0184
Copy link
Author

It'd probably be easier to show rather than tell: https://github.com/monoxide0184/ForgeBackup/blob/master/build.xml

In short, we have a separate src folder from MCP and to date that project has also compiled to our own bin folder too. BON worked great for that (small) project, but when I tried to move that build system across to a larger project I ran into the issues above. Reason I want to stick with this system? Well, mostly because 4 second builds in jenkins are awesome. I may just try to hack it together with MCP's reobf though if this really isn't supported in BON.

@wgaylord
Copy link

Sorry for the bump. MCP uses SS to reobf plus the mappings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants