-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after crop and save to gallery #11800
Comments
I have the same error when cropping images on Android. App version is 1.112.1 installed from github through Obtanium. Docker logs for immich_server don't show anything unusual. I believe this must be an Android app problem and not a server problem. |
I have the same issue on Docker/Debian. |
I get exactly the same issue. I didn't even crop, just rotate from the mobile app.
|
Same issue, on a Pixel 7A. I think i've had about 2 successful crops out of about 10 attempts. Most of the crops don't appear anywhere on the phone or on the server, despite the 'Image saved' notification (which appears before the 'Null check operator...' notification. Not sure it's related, but often when i launch the Android app, i just get the Immich logo frozen on the screen for a minute or so before loading the thumbnails. |
I saw the same error when trying a rotate (no crop). |
Seeing the same issue on a Pixel 8, running Android 14. Immich android app version 1.112.1 build.154, server version 1.112.1 as a docker container. Steps to reproduce:
Turning the app log level to INFO, I believe this is the relevant log entries to coincide with the app error:
|
With version 1.113.0 it no longer displays the error message and seems to save the cropped image, although in a different location. Original image was at /storage/emulated/0/DCIM/Camera and crop save location is /storage/emulated/0/Pictures |
Yes, great progress, i'm now able to save cropped images to the server. Would be great if the cropped image could preserve the date of the original image. And maybe ask if the original (uncropped image) should be deleted? |
Great idea @mikerjensen , I would like to proceed, but just needs the confirmation if we wanted to have the functionality of deleting the orginal photo's once it is cropped and saved into new ones ? |
Thanks, well mostly i delete the original, but sometimes I crop
the original photo twice - to focus on a different part of the
image each time, and sometimes one might still want to retain the
original after making a crop, so it would be good to have
something like a 'delete original?' dialogue after each crop?
On 10/7/24 21:17, Yashraj Jain wrote:
Great idea @mikerjensen
, I would like to proceed, but just needs the confirmation if we
wanted to have the functionality of deleting the orginal photo's
once it is cropped and saved into new ones ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message
ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#11800 (comment)",
"url": "#11800 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
Great @mikerjensen , I can start working on this. But I think this card isn't relevant to the issue that we are proceeding on, so can we start with a new issue, where we can start there and close this issue, as this is fixed. |
Hey @mikerjensen , as you mentioned, I have added the new functionality of asking a user to delete the orginal image after the crop functionality. |
This is really great!, I can't wait to try it! Also wondering if
some key image info might be preserved - perhaps you also included
that in the upcoming version, as currently it seems that that the
cropped image doesn't include the location info?
On 10/8/24 12:23, Yashraj Jain wrote:
Hey @mikerjensen
, as you mentioned, I have added the new functionality of asking
a user to delete the orginal image after the crop functionality.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message
ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#11800 (comment)",
"url": "#11800 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
I see the same with 1.118.0. ie, on android - Edit photo - say apply rotation |
The bug
After cropping a photo and trying to save it to the gallery:
The OS that Immich Server is running on
Unraid
Version of Immich Server
1.112.0-1
Version of Immich Mobile App
1.112.1 b154
Platform with the issue
Your docker-compose.yml content
.
Your .env content
.
Reproduction steps
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: