Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): fix text search #14873

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

johnstef99
Copy link
Contributor

Fixes #14814

@johnstef99
Copy link
Contributor Author

This commit f59b813 changed how SearchFilter.copyWith handles null value for context and filename but this created this bug #14814 where when you apply other filters the context and filename always get turned into null.

Passing empty string at the context or the filename filter is necessary to remove the filter when the user submits the search field with no text. The SearchService handles it by checking if the strings context and filename are empty.

I think this answers both of the above questions.

@alextran1502
Copy link
Contributor

Can you please write down some functional test cases and how you verified that they are fixed with this change?

@johnstef99
Copy link
Contributor Author

Can you please write down some functional test cases and how you verified that they are fixed with this change?

sure I will write some tests to verify that the search is working as inteded. If these tests existed this commit f59b813 would have failed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Search bug
3 participants