Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date ranges in albums ignore the time zone #13737

Closed
1 of 3 tasks
asusplayer opened this issue Oct 25, 2024 · 1 comment · Fixed by #15654
Closed
1 of 3 tasks

Date ranges in albums ignore the time zone #13737

asusplayer opened this issue Oct 25, 2024 · 1 comment · Fixed by #15654
Labels
date-time Issues with date/time/time zone

Comments

@asusplayer
Copy link

The bug

When creating an album from photos taken at the end of the month, it's possible for the displayed date range to extend beyond the last photo. This probably happens, because the date range does not account for the different time-zone.

Screenshot 2024-10-25 203705

The OS that Immich Server is running on

Portainer, Ubuntu 22.04.5

Version of Immich Server

v1.118.2

Version of Immich Mobile App

v1.118.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#

name: immich

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.transcoding.yml
    #   service: cpu # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    volumes:
      # Do not edit the next line. If you want to change the media storage location on your system, edit the value of UPLOAD_LOCATION in the .env file
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - stack.env
    ports:
      - '2283:2283'
    depends_on:
      - redis
      - database
    restart: always
    healthcheck:
      disable: false

  immich-machine-learning:
    container_name: immich_machine_learning
    # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.
    # Example tag: ${IMMICH_VERSION:-release}-cuda
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration
    #   file: hwaccel.ml.yml
    #   service: cpu # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable
    volumes:
      - model-cache:/cache
    env_file:
      - stack.env
    restart: always
    healthcheck:
      disable: false

  redis:
    container_name: immich_redis
    image: docker.io/redis:6.2-alpine@sha256:2ba50e1ac3a0ea17b736ce9db2b0a9f6f8b85d4c27d5f5accc6a416d8f42c6d5
    healthcheck:
      test: redis-cli ping || exit 1
    restart: always

  database:
    container_name: immich_postgres
    image: docker.io/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      POSTGRES_INITDB_ARGS: '--data-checksums'
    volumes:
      # Do not edit the next line. If you want to change the database storage location on your system, edit the value of DB_DATA_LOCATION in the .env file
      - ${DB_DATA_LOCATION}:/var/lib/postgresql/data
    healthcheck:
      test: pg_isready --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' || exit 1; Chksum="$$(psql --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' --tuples-only --no-align --command='SELECT COALESCE(SUM(checksum_failures), 0) FROM pg_stat_database')"; echo "checksum failure count is $$Chksum"; [ "$$Chksum" = '0' ] || exit 1
      interval: 5m
      start_interval: 30s
      start_period: 5m
    command:
      [
        'postgres',
        '-c',
        'shared_preload_libraries=vectors.so',
        '-c',
        'search_path="$$user", public, vectors',
        '-c',
        'logging_collector=on',
        '-c',
        'max_wal_size=2GB',
        '-c',
        'shared_buffers=512MB',
        '-c',
        'wal_compression=on',
      ]
    restart: always

volumes:
  model-cache:

Your .env content

UPLOAD_LOCATION=/mnt/immich/upload
DB_DATA_LOCATION=/mnt/immich/db
IMMICH_VERSION=release
DB_PASSWORD=-----------------
DB_USERNAME=----------------
DB_DATABASE_NAME=immich

Reproduction steps

  1. Set time-zone to something different (for me GMT+2)
  2. Upload image that was taken at the end of a day at the end of a month (e.g. 11pm)

Relevant log output

No response

Additional information

No response

@C-Otto C-Otto added the date-time Issues with date/time/time zone label Jan 24, 2025
@C-Otto
Copy link
Contributor

C-Otto commented Jan 25, 2025

Confirmed in v1.125.2. The photos are shown with the local date (assets.localDateTime), whereas the album date range uses the photos' UTC date (assets.fileCreatedAt or exif.dateTimeOriginal). The UTC date/time might be on a different date than the local time, depending on time zone offset details, which causes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
date-time Issues with date/time/time zone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants