Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMAP from reference is not transfered to samples - Symphony Seurat #25

Closed
NK-HD opened this issue Jan 16, 2022 · 2 comments
Closed

UMAP from reference is not transfered to samples - Symphony Seurat #25

NK-HD opened this issue Jan 16, 2022 · 2 comments

Comments

@NK-HD
Copy link

NK-HD commented Jan 16, 2022

Dear Symphony Team,

please excuse me opening another issue on this topic!
Following your vignette (https://github.com/immunogenomics/symphony/blob/main/vignettes/Seurat.ipynb) i managed to run the complete script without errors (I rerun the RunHarmony.Seurat on my existing (already before to umap processed) object and then followed the vignette).

However the resulting query UMAP looks like this:
73927f34-3d28-4756-9b31-5de4554b5d4a

Running the vignette works fine and i can also map my query data on your reference. So the problem appears to be during the reference construction. In the generation of my refobject I removed some confounding genes from the ScaleData and RunPCA step.
I noticed that in order for the script to run without errors I have to remove those also from the variable features in the refobject, but I kepp getting this very wird umap after mapquery. (The initial umap before reference building looks fine)

Do you have any idea what could cause this error?

Thanks a lot for your help!!! I realy appreciate it!
Best,
Niklas

@joycekang
Copy link
Collaborator

Hi Niklas,

Thanks for your message! I'm not entirely sure what is causing this error - would you mind trying it again but removing the confounding genes prior to the variable gene selection part? Perhaps there is something buggy in the way you are manually removing them (though it's doubtful it would have such a large effect). Secondly, when you run FindNeighbors and RunUMAP2, are you sure that it's being run on the embedding = 'harmony' and not the PCA embedding?

@joycekang
Copy link
Collaborator

Closing this issue, but feel free to reopen if still not resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants