Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PresentationDefinitionId's #139

Open
5 tasks
Oran-Dan opened this issue Oct 22, 2024 · 2 comments
Open
5 tasks

feat: add PresentationDefinitionId's #139

Oran-Dan opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
Added A new feature that requires a minor release.

Comments

@Oran-Dan
Copy link
Contributor

Description

Currently we have our PresentationDefinitions (PD) hardcoded in agent_verification/presentation_definitions/presentation_definition.json and in our postman collection.

In the future we want to work PDId's in (most of) our API interactions. This will be much cleaner and easier for external parties to use and more scalable.

Motivation

Makes working with PD's much smoother and also aligns with other parties in our field

Resources

No response

To-do List

  • We need a seperate table in our postgresql database of key-value pairs of PDId's and there PD's.
  • Aggregates must be added to maintain this data domain.
  • API's must be added along with their adapters and commands to be able to interact with the database, to fetch, add or delete a PD.
  • These actions need to publish events
  • Existing code must be update to work with PDId's instead of directly with PD's.
@Oran-Dan Oran-Dan added the Added A new feature that requires a minor release. label Oct 22, 2024
@Oran-Dan Oran-Dan self-assigned this Oct 22, 2024
@nanderstabel
Copy link
Collaborator

Related: #100

@M-Adam-Hus
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release.
Projects
None yet
Development

No branches or pull requests

3 participants