Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type generated does not respect "required" flag in proto #260

Open
pennyshen opened this issue Dec 17, 2020 · 1 comment
Open

Type generated does not respect "required" flag in proto #260

pennyshen opened this issue Dec 17, 2020 · 1 comment
Labels

Comments

@pennyshen
Copy link

Versions of relevant software used
0.13.0

What happened
When I generate a proto where a field is marked required, the corresponding AsObject type for that field is still optional. This is shown in the example files as well: my_double is required in proto, yet in the generated file, myDouble is optional (i.e., myDouble?: number

What you expected to happen
Required fields are translated as required in type definition.

How to reproduce it (as minimally and precisely as possible):
See example files linked.

Full logs to relevant components

Anything else we need to know

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant