-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto3 - required / optional fields #287
Comments
@AmitM30 Have you solved this issue somehow? :) Thanks in advance. |
@davidslaby No. I am living with it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I came here to find out which arguments we need to pass to fix this behavior as well - most of the types generated from our protos say the fields are there when they could be missing. I would expect all of these to have |
Versions of relevant software used
0.15.0
What happened
I am using
proto3
, and after generating the typescript schema, only some fields are marked as optional. While, afaik, everything should be optional by default.What you expected to happen
In the following definition:
link
is marked as optional, restrequired
. Not sure why.How to reproduce it (as minimally and precisely as possible):
we could use the above definition and reproduce this.
link.proto
Full logs to relevant components
Anything else we need to know
The text was updated successfully, but these errors were encountered: