From b4cbc95eb81790e70c623729499c34f49cf48ca3 Mon Sep 17 00:00:00 2001 From: John Kjell Date: Thu, 11 Jan 2024 13:05:07 -0500 Subject: [PATCH] Address some review feedback Signed-off-by: John Kjell --- .github/ISSUE_TEMPLATE/bug-report.md | 1 + .github/ISSUE_TEMPLATE/feature-request.md | 4 ++-- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++++++++-- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index aca9f5b1..1efbee32 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -21,5 +21,6 @@ assignees: '' **Environment:** - Witness version: +- Architecture: - Attestors used: - Archivista version: diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 30394e12..a8540f67 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -29,8 +29,8 @@ assignees: '' **Testing changes required:** -[List possible testing changes required, if none please explain] +[List possible testing changes required, if none please explain, if unsure assignee will assist] **Documentation changes required:** -[List possible documentation changes required, if none please explain] +[List possible documentation changes required, if none please explain, if unsure assignee will assist] diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8e62f1e8..0d0d900f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,19 @@ -**What this PR does / why we need it**: +## What this PR does / why we need it + +Description + +## Which issue(s) this PR fixes (optional) + +(optional, using `fixes #(, fixes #, ...)` format, will close the issue(s) when the PR gets merged)* -**Which issue(s) this PR fixes** *(optional, using `fixes #(, fixes #, ...)` format, will close the issue(s) when the PR gets merged)*: Fixes # +## Acceptance Criteria Met + +- [ ] Docs changes if needed +- [ ] Testing changes if needed +- [ ] All workflow checks passing (automatically enforced) +- [ ] All review conversations resolved (automatically enforced) +- [ ] [DCO Sign-off](https://github.com/apps/dco) + **Special notes for your reviewer**: