Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on etn in sql file calls #47

Open
Tracked by #45
PietrH opened this issue Sep 27, 2024 · 0 comments · May be fixed by #49
Open
Tracked by #45

remove dependency on etn in sql file calls #47

PietrH opened this issue Sep 27, 2024 · 0 comments · May be fixed by #49
Assignees
@PietrH
Labels
actionable Can be implemented bug Something isn't working

Comments

@PietrH
Copy link
Member

PietrH commented Sep 27, 2024 •
edited
Loading

In a number of places etnservice calls files from etn, this is unwanted behaviour, these files have now been copied over to etnservice and references should be made relative to included files instead of an external dependency instead.

example

  project_sql <- glue::glue_sql(
    readr::read_file(system.file("sql", "project.sql", package = "etn")),
    .con = connection
  )
@PietrH PietrH mentioned this issue Sep 27, 2024
Open
2 tasks
@PietrH PietrH changed the title remove dependency on etn remove dependency on etn in sql file calls Oct 2, 2024
@PietrH PietrH self-assigned this Oct 2, 2024
@PietrH PietrH added bug Something isn't working actionable Can be implemented labels Oct 2, 2024
@PietrH PietrH linked a pull request Oct 2, 2024 that will close this issue
Use included SQL files instead of those included in etn #49
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PietrH PietrH

Labels
actionable Can be implemented bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use included SQL files instead of those included in etn inbo/etnservice
1 participant
@PietrH