-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new station names to raw data files #43
Comments
|
Files with NOT FOUND = couldn't find station name directly. Will look those up with the receiver code. |
I noticed the NOT FOUND are dependant on date, @PieterjanVerhelst, maybe it is better if you map those. |
I filled in the new names (last column): |
I have some code to read raw input files. It detects the format based on the headers, so it knows in which columns the values need to be changed. I also have a command line script that does the aggregation. So I would suggest to update these script and have them change the station names too and write these files to the verified folder. I'll leave the files in the Raw folder, so after manual validation, you can remove them. |
|
@bartaelterman : let me know when the raw files where verified. Afterwards I will check them in the raw folder and delete them. |
Yes @PieterjanVerhelst, I can add the new station name based on receiver id. The receiver id is:
? |
There are some faults in the metadata about the Meuse receivers (ma-x); I am trying to correct it by the end of the week. |
Here are the receiver_id's with the matching station names. Some receivers were removed and changed by another receiver for the same location and got deploy number '2'. receiver_id is_active station_name deploy_number |
Did the opposite happen too? A receiver was redeployed on a different location? |
It was removed and deployed again, but still at the same location (ma-3) |
Ok. So the station code stays the same then. I'll write a script to substitute the station names and will send you a file this afternoon. |
I am wondering... Replacing the old station names by new ones is ok. After some iterations, no old station names will be found in the input anymore, and this step will eventually become obsolete. Setting the station name based on the receiver id works differently since the receiver id always stays the same. So this action will always remain active. If at some point in the future we do move one receiver from one station to another, we are in trouble. Are we absolutely sure this is how we want to process the raw data? |
In the future, the correct station name will come with the csv file, so this step will be unnecessary. I would not set the station name based on the receiver ID for the above mentionned reason: receivers will be translocated in the future (old projects end, new ones arise). Only in the exceptional case of the Meuse receivers (see above), because no station name was given to the receivers, so the only info we have in the csv file is the receiver ID. |
That's exactly my point. I cannot implement this exceptional case in a script. Setting the station name of these receivers will need to be done manually. |
I will change this in the csv files and drop them in verified folder. Afterwards, I will delete them from the Raw folder. |
The station names for the Meuse receivers were added and the files are in the Raw folder (as well as the original files). If ok for you, I will delete the old files. |
Where are we with this step? Anything I need to do? |
I also noticed doubles in the raw folder: the csv file and a google spreadsheet of the same csv file. Can the google spreadsheets be removed? |
Indeed, the google spread sheets can be removed. |
Now removed. |
Almost there. I have a couple of files that don't contain a station name, only a receiver id. For at least the following ids, I would need a new station name.
These can be added to the station names file in the |
See #43 (comment) 3219761 There are additional receivers in the Google Spreadsheet without a station, but didn’t add them (yet).
Done. See commit above. |
With that, I can validate all data in the Raw folder. How shall we go from here:
|
If @PieterjanVerhelst agrees with the above, I would just have:
|
@bartaelterman: you have got the new station names for the above mentionned receivers? As these are in the file station_names.csv ?
|
@PieterjanVerhelst Jep, I have the station names for the above mentioned receivers.
|
|
|
Agree with @bartaelterman: let's try to cover everything with a script if we can. Also agree to drop |
So @PieterjanVerhelst can you add the mapping of the missing receivers to station_names.csv? |
To clarify, those that you mentioned in:
|
|
|
Consolidated would contain the separate csv files? In that case ok. I thought in that map the concatened file without aggregation would be dropped. |
Consolidated would contain 1 file with all records in 1 format. Not aggregated, but not separate files. Why is it important to have separate files? |
I don't know. I will check this with VLIZ. |
It would be important to have the separate verified files to check the consolidated file if data is missing. |
StationName
with the correct values@bartaelterman, what would be the best approach to do step one with a script?
The text was updated successfully, but these errors were encountered: