Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split arch_test.h into two files #21

Open
Alenkruth opened this issue Apr 20, 2022 · 1 comment · Fixed by #24
Open

Split arch_test.h into two files #21

Alenkruth opened this issue Apr 20, 2022 · 1 comment · Fixed by #24
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Alenkruth
Copy link
Contributor

Split the arch_test.h into

  1. arch_test_priv.h - will contain sections from the current arch_test which is required only when the test is a privileged test. These include

    • supervisor/user entry/exit macros
    • supervisor/user trap handler
    • machine trap handler
    • interrupt set/clear macros
  2. arch_test_unpriv.h - will contain sections from the current arch_test which is required for normal test execution. These include

    • instruction macros
    • migration aliases
@Alenkruth Alenkruth added enhancement New feature or request good first issue Good for newcomers labels Apr 20, 2022
@Alenkruth Alenkruth self-assigned this Apr 20, 2022
Alenkruth added a commit that referenced this issue May 5, 2022
As mentioned in #21, this commit attempts to split the arch test file into
privileged and upnprivileged files which contain the macros as mentioned in the issue.
@Alenkruth
Copy link
Contributor Author

@neelgala please check if this would work as you intended -> bd65ac0

@Alenkruth Alenkruth reopened this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant