Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull images before running docker-compose up #179

Open
wants to merge 8 commits into
base: release/2.3.0
Choose a base branch
from

Conversation

samuelbernardolip
Copy link
Collaborator

@samuelbernardolip samuelbernardolip commented Feb 3, 2022

Fixes #177
What is missing on this PR:

  • Requires testing with real use case, where images are being created or modified
  • Documentation is not yet updated

@samuelbernardolip samuelbernardolip added bug Something isn't working documentation labels Feb 3, 2022
@samuelbernardolip samuelbernardolip added this to the 2.1.2 milestone Feb 3, 2022
@samuelbernardolip samuelbernardolip self-assigned this Feb 3, 2022
@samuelbernardolip samuelbernardolip changed the base branch from release/2.1.1 to release/2.3.0 June 10, 2022 00:07
…rce build image with native docker

Signed-off-by: Samuel Bernardo <[email protected]>
@samuelbernardolip samuelbernardolip modified the milestones: 2.1.2, 2.3.0 Jun 10, 2022
@samuelbernardolip samuelbernardolip linked an issue Jun 10, 2022 that may be closed by this pull request
@samuelbernardolip samuelbernardolip marked this pull request as ready for review June 10, 2022 00:51
Correct if syntax
Missing initialization of cmdCommon variable.
Temporarily remove the forcing pull to test the API
Separate force pull from force build with the following environment variables support:
JPL_DOCKERFORCEPULL
JPL_DOCKERFORCEBUILD
@orviz orviz requested review from orviz and removed request for vykozlov January 2, 2023 10:14
Copy link
Member

@orviz orviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting JPL_DOCKERFORCEPULL setting is required before merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose up don't respect pull policy
2 participants